Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document common peer dependency warnings #3653

Closed
wants to merge 4 commits into from

Conversation

88kami88
Copy link

@88kami88 88kami88 commented Dec 27, 2017

warning "@ethersage/react-scripts > react-hot-loader > [email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning "@ethersage/react-scripts > react-hot-loader > [email protected]" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0".

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@88kami88 88kami88 changed the title Warnings Document common peer dependency warnings Dec 27, 2017
@88kami88 88kami88 closed this Dec 27, 2017
@88kami88
Copy link
Author

Meant to open this against my fork, sorry.

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants